PIC Microcontoller Math Method

Multiply 8 x 8 bits

Posted to the PICList

; Enter with multiplier in W-Reg, multiplicand in "PRODLO".
; Exits with product in PRODHI:PRODLO.

	MPY8X8:

	CLRF PRODHI

	CLRF COUNT
	BSF COUNT,3

	RRF PRODLO,F

	LOOP:

	SKPNC
	ADDWF PRODHI,F
	
	RRF PRODHI,F
	RRF PRODLO,F

	DECFSZ COUNT
	GOTO LOOP

This can also be unrolled for an even faster (and not much larger version)

;***************************************************************************
;**  time efficient multiplication 8 bit x 8 bit = 16 bit (unsigned)
;**
;**  company:       elektronik 21 GmbH
;**  programmer:            Martin Schaefer (idea from Andrew Warren)
;**
;**  execution time:  fixed 38 cycles  (with jump in and jump out) !!!
;**  code length:           35 words
;**  multiplier:            w
;**  multiplicand:    resultlo
;**  result:        resulthi:resultlo
;***************************************************************************
MUL8X8   CODE
Mul8x8                          ;* 2 cycles for call - instruction
        GLOBAL Mul8x8, resulthi, resultlo

mult    MACRO
        btfsc   STATUS,C
        addwf   resulthi,F
        rrf     resulthi,F
        rrf     resultlo,F
        ENDM

        clrf    resulthi                ;* 1 cycle
        rrf     resultlo,F              ;* 1 cycle

        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles
        mult                            ;* 4 cycles

        retlw 0                 ;* 2 cycles
;***************************************************************************

See also:

Questions:

headsmess@gmail.com asks:
i dont get the BSF count,3 line.

i am seeing...

clear result file and count file.
set count bit(s) for desired number of loops.

enter loop, decrement count file 1 bit, skip if clear.
add result to original, shift one place left.

repeat.

setting bit 3 only gives me five loops dont it? 0100= 4. shouldnt it be 000-0111, aka bits 3,2,1, for 8 loops in total? or bit 4? im also confused if i count 0 as a cycle or not :)

or am i not seeing something/not understanding something here?

i must be, noone else is saying anything!
James Newton of MassMind replies: Bit number 3 is the 4th bit in COUNT. Think of it this way, BSF COUNT,0 would set the 1st bit. Setting the first bit, makes COUNT 8.
jb79_ATT_gmx_DOTT_at asks:
The destination (where the values are stored) are missing in Andrew Warren's multiplication script, MPLAB told me during the compilation that it will use the default destinations. Is this correct or can anybody tell me the correct destinations (f or w) for all the script lines where a destination should be inserted to specify where the calculation output should be saved?

Thanks for your help
James Newton of Massmind replies: As the documentation says, the output is save in PRODHI:PRODLO. You decide what those labels point to by assigning the labels values in your code.
sarah_qennah@yahoo.com asks:
write an algorithm in PIC16F874 assembly to 8x8 bit unsigned multiplication . Multiplies M1 & M2 leaving the result in Rhi & Rlo .
It loops through the addition of M2 to itself M1 times.
James Newton replies: "It puts the book on its table and it reads it in..."

Comments:

I thought at first there might be a problem if the routine was called when Cy was set, however on examination I realised that PRODLO is shifted 9 times in total = so any spurious Cy shifted in at the start is shifted out at the end = very clever !
Other code snippits I've seen (including Microchips own AN526) waste an instruction to BCF the carry ...
jb79_ATT_gmx_DOTT_at
Hello again!
The code works with the destination "f", I also did some tests, it seems the default destination is everytime the register itself, the W register is never changed by instructions with missing destination.
So we can say (for example): "RRF registername,1" is eqal to "RRF registername" and also "RRF registername,f", the only thing is that some compilers/linkers don't like the shorter instruction code and produce an information message.

Thanks again for your help.
jb79_ATT_gmx_DOTT_at
Hello James!
Thanks for the reply, I know about the fact where the result of the multiplication will be stored.
Sorry that my question was not well formulated, so I try again. Some instuctions for the PIC microprocessor like ADDWF need a destination, normally the W register or the register where the value comes from. So the full syntax of this command would be ADDWF PRODHI,0 when the result of the calculation should be stored in the W register or ADDWF PRODHI,1 if the result should overwrite the old value stored in the PRODHI register. That's what my question is about, this destination is missing in the code example from Andrew Warren and my compiler (MPLAB/MPLINK) told me that the default destination was used, maybe this is wrong and so the calcualtion wouldn't work.

James Newton of Massmind replies: Ah, ok... based on the fact that the macro example uses ",f" as the destination, I assume the original code should also use that as the destination. I've edited the page to make that correction. I'm not sure what MPLAB uses as the default destination, but if it is the file register and not W, then the code would work fine as originally written.