> I'm jumping to Andy's defence for a couple of reasons: he's not
> around to defend himself and he has written some extremely good code
> - and shared it.

> 2) Andy doesn't comment all of his code. =A0That doesn't mean that its
> bad code. =A0In fact, it doesn't mean anything at all except that he
> didn't comment his code.

We can possibly have a win-win here.
Or lose-lose :-)

It's commonly held that not to comment code is bad practice.
The reasons are well known and generally sound.
So, the assertion "bad code" may pass muster if rendered "bad practice".

In fact, fwiw, there was SOME documentation - it was in the way the
EQUs were presented, which caused the original query :-).

Many claim that they will subsequently remember what code did and why
they did what they did, and it's only for their use anyway etc. Most
lie. Some few may have such a grasp of their subject that all is
obvious at a glance. If Isaac Newton had programmed PICs he would have
had such a grasp (I think he actually used an NMOS General Instruments
1650).

Some argue that sometimes when mere mortals sit at the feet of masters
they should expect to take what they get with gratitude. I understand
that at one party to this thread is keen on that argument ;-). A major
master will ideally do things out of consideration for lesser mortals,
lest others who can ill afford to follow their 'bad examples'. I'm
told that when Hawkings answers a question the answer may
(understandably) be short and cryptic - but you take what you get
because asking again is liable to be bad overall.

So given the EQUates situation, we may be able to go with 'bad
practice for most mortals, and leave the code comment out.

FWIW (very little).

I always did wonder where the barrel roll bit swap W saving code came
from and why anyone would consider making a prcessor that would need
it. Now we know the answer to the first part. GI will probably have
taken the answer to the 2nd with them when they left the building .


       R

-- =

http://www.piclist.com PIC/SX FAQ & list archive
View/change your membership options at
http://mailman.mit.edu/mailman/listinfo/piclist