> Is this a good way, or is there a much better way?

Jason, for a repetitive signal like that there would be other ways
that would probably give you the same result to a pretty reasonable
degree

Using the ADC would work, but might be considered more of a
qualitative method than quantitative. IOW, it's not really necessary
to examine the absolute shape of the waveform

(1) The +ve-going and -ve-going transition points on any particular
PIC pin will flip the pin value. Look at the PIC's pins as very crude
ADC. It would be possible, for example, to use INT0, alternate the
edge polarity, measuring the '0' and '1' periods with a timer. Or a
CCP pin and CCP module

(2) the PIC's internal comparator

-- 
http://www.piclist.com PIC/SX FAQ & list archive
View/change your membership options at
http://mailman.mit.edu/mailman/listinfo/piclist