Harry H. Arends wrote:
> Dont have to if i know that all those registers are in bank0

Don't have to what exactly?  Pay attention to banking?  If so, then
absolutely not.

You shouldn't be hard coding assumptions about what registers are in what
banks in the code.  In the very rare cases where every instruction is
precious and you want to manually optimize bank switching, there must be
clear comments explaining the bank assumptions and what you're doing.

Your code had nothing warning of bank assumptions and the definition of the
variables was not shown.  And no, I'm not going to look up the SFRs to see
what bank they're in.

> so please tell me what is wrong with that?

Banking will continue to be a issue until you prove it's not.  And, until
banking has been addressed, it's pointless to look at the code past that.

> Normal code is always in bank0 unless otherwise

Huh?  I guess all my code is abnormal then.  I find it amusing that someone
who has to ask here about basic PIC programming thinks they are in a
position to declare what "normal" is.


********************************************************************
Embed Inc, Littleton Massachusetts, http://www.embedinc.com/products
(978) 742-9014.  Gold level PIC consultants since 2000.
-- 
http://www.piclist.com PIC/SX FAQ & list archive
View/change your membership options at
http://mailman.mit.edu/mailman/listinfo/piclist