On Tue, 11 Mar 2008, William "Chops" Westfield wrote:

> We had this gem (I think I've sanitized it enough for "the public")
> 
>      if (match_number(csb, 0, MAXUSHORT, &i, var2, flags, NULL) &&
> 	match_char(&csb->line[csb->line_index], &i, ':') &&
> 	((got_num_colon = TRUE)) &&	/* Remember we got "<number>:" */
> 	match_number(csb, 0, MAXULONG, &i, var3, flags, NULL) &&
> 	match_whitespace2(...)) {
> 	/* Stuff */
> 	return;
>      }
> 
> No amount of multiple parens made a new compiler happy about that line
> with "got_num_colon" in it.  And there was about a 50% chance that the
> person fixing it would fix it wrong, even with the comment...

Count yourself lucky. I've seen code like:

	((x < max_something) && (a = 5, b = 6, c = 7)) ||
	((x == max_something) && (a = j, b = k, 1)) ||
	((a = 25, b = 26, c = 23));


Regards
Sergio
-- 
http://www.piclist.com PIC/SX FAQ & list archive
View/change your membership options at
http://mailman.mit.edu/mailman/listinfo/piclist