In SX Microcontrollers, SX/B Compiler and SX-Key Tool, John Kauffman wrote:

[3]
Can this code be more compact / more elegant?
[/3]
[3][/3] 

[3]Below is some SX/B code that is very easy to understand; it flashes an LED if both switches are closed. [/3]

[3]Now I want to get it into as few lines (and as elegant) as possible. Any suggestions?[/3]

[3]Is there some way to do this with a variable sized bit instead of byte?[/3]

[3]Can I avoid the variable completely?[/3]

<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" /><o:p> </o:p>

' code to flash MyLed when Switch1 AND Switch2 are closed

' Switch<SPAN style="mso-spacerun: yes">  pins use internal pull-up so open = 1

<o:p> </o:p>

' IO Pins

MyLed<SPAN style="mso-tab-count: 2">       <SPAN style="mso-tab-count: 1">      PIN<SPAN style="mso-tab-count: 1">   RC.0

Switch1<SPAN style="mso-tab-count: 2">           pin<SPAN style="mso-tab-count: 1">   RB.1

Switch2<SPAN style="mso-tab-count: 2">           pin<SPAN style="mso-tab-count: 1">   RB.2

<o:p> </o:p>

' Variables

SwitchTotal<SPAN style="mso-tab-count: 1"> <SPAN style="mso-tab-count: 1">      var<SPAN style="mso-tab-count: 1">   byte

<o:p> </o:p>

<?xml:namespace prefix = st1 ns = "urn:schemas-microsoft-com:office:smarttags" /><st1:place w:st="on">Main</st1:place>:

SwitchTotal = 0

SwitchTotal = SwitchTotal + Switch1

SwitchTotal = SwitchTotal + Switch2

IF SwitchTotal = 2 THEN

<SPAN style="mso-tab-count: 1">      HIGH MyLed

<SPAN style="mso-tab-count: 1">      Pause 500

<SPAN style="mso-tab-count: 1">      HIGH MyLed

<SPAN style="mso-tab-count: 1">      Pause 500

ENDIF

GOTO <st1:place w:st="on">Main</st1:place>

---------- End of Message ----------


You can view the post on-line at:
http://forums.parallax.com/forums/default.aspx?f=7&p=1&m=157351

Need assistance? Send an email to the Forum Administrator at forumadmin@parallax.com

The Parallax Forums are powered by dotNetBB Forums, copyright 2002-2006 (http://www.dotNetBB.com)