On Oct 15, 2004, at 9:42 AM, Byron A Jeff wrote: > On the extremely rare cases that I actually used it, > I make sure to add a big bold comments to the fact. > Check out THIS lovely example: if (match_number(csb, 0, MAXUSHORT, &i, var2, flags, NULL) && match_char(&csb->line[csb->line_index], &i, ':') && ((got_num_colon = TRUE)) && /* Remember we got ":" */ match_number(csb, 0, MAXULONG, &i, var3, flags, NULL) && match_whitespace2(&csb->line[csb->line_index], &i, csb->in_help)) { *var1 = VPN_RD_TYPE_0; : Think that "got_num_colon = TRUE" in the middle of the if statement belongs there, or not? It ALMOST got by a very experienced engineer when a new compiler complained about it... And it HAS a comment! :-) BillW PS: Don't forget fortran's infamous "DO 10 I = 1.20" _______________________________________________ http://www.piclist.com View/change your membership options at http://mailman.mit.edu/mailman/listinfo/piclist