> After some investigation I had soldered everything back together with > it turned on Ooops > I had also gotten a bridged joint Ooops Have you tried another chip ? A reasonable investigative step > Could someone take a look at it and tell me if my code might work > at what I am trying, thanks... At first glance it looks OK and seems to compile alright. Assuming no other electrical horrors have been or are currently inflicted on the poor thing it should work There are a few things you could do to make the code a little more readable and quicker/easier to type For example, use XOR to toggle bits (be aware of read-write-modify when changing port bits directly. It sometimes pays to manipulate bits in a shadow register, which is then written to the port). 0XFF will simply invert the state of all the PORTA bits MOVF PORTA,W ;perhaps copy W to a shadow register here XORLW 0XFF ;or b'11111111' MOVWF PORTA ;or write the shadow register via W back to the port or MOVLW 0XFF XORWF PORTA XOR can be used to turn a bit off (if it was on, but there's more to it than that which could impact on other port bits), IOR to turn it on. Try a few binary examples in a Watch window. For individual bits, define them so you can address them by name eg #DEFINE testpoint1 PORTA,0 CLRF instead of MOVLW 0X00, MOVWF RETFIE instead of GOTO END_INT (saves reader looking for END_INT) BANKSEL TRISA to go to Bank1 BANKSEL PORTA to go to Bank0 -- http://www.piclist.com hint: To leave the PICList mailto:piclist-unsubscribe-request@mitvma.mit.edu