William Chops Westfield wrote:
> hz_7            equ     240             ;140 mS
> hz_17           equ     140             ;59 mS
> hz_28           equ     95              ;36 mS
> ms_35           equ     8               ;time that LED is on
> volt7           equ     180             ;battery 7 volts

I don't like this, but not for the reason we've been discussing.  If you
want a battery level of 7 volts, there should be a constant that lets
selects that in obvious human-readable units, like millivolts:

battmv    equ    7000  ;battery threshold, mV

After that you can use assembler math to compute the 180 value using
whatever conversion is required.  Any conversion constants should also be
defined in reasonable user terms.  This not only documents what the battery
threshold is, but allows easy changes in the future without having to know
the conversion magic from 7 to 180.


*****************************************************************
Embed Inc, embedded system specialists in Littleton Massachusetts
(978) 742-9014, http://www.embedinc.com

--
http://www.piclist.com hint: PICList Posts must start with ONE topic:
[PIC]:,[SX]:,[AVR]: ->uP ONLY! [EE]:,[OT]: ->Other [BUY]:,[AD]: ->Ads