What I do, when I debug or try something is to read each bit of a byte
and write it down....

0010.0000

Now, I readed all bits and decided their value. Next trasnlate that to
HEX

0x20

And use that value. It=92s a small consice and understandable (for me)
code. Atlist for the next two hours before I erase the test and write
the real code down.

Mauricio Jancic
Janso Desarrollos
Microchip Consultant
(54) - 11 - 4542 - 3519

-----Original Message-----
From: pic microcontroller discussion list
[mailto:PICLIST@MITVMA.MIT.EDU] On Behalf Of Tony K=FCbek
Sent: Viernes, 03 de Octubre de 2003 06:32
To: PICLIST@MITVMA.MIT.EDU
Subject: Re: [PIC:] USART on 18F452...


Hi,

On that note, I'd like to add: why does people not use the Microchip
defines ? each and every bit has corresponding defines in the include
file. This way, aprt from making the codes easier to read, will make it
much less prone to errors. For example this snippet:

<snip>
>      TXSTA =3D 0x20;
>       RCSTA =3D 0x80;
<snip>

I would write as (in asm):

        ; enable transmitter
        MOVLW   (1<<TXEN) ; enable transmitter (note: low speed mode,
BRGH =3D 0 )
        MOVWF   TXSTA,A=09

        ; enable recevier
        MOVLW   (1<<SPEN) ; serial port enable=20
        MOVWF   RCSTA,A=09

Or in c:

       TXSTA =3D (1<<TXEN);
       RCSTA =3D (1<<SPEN);

If several bits are to be set then something like this:
        ; enable recevier
        MOVLW   (1<<SPEN)|(1<<CREN) ; serial port enable and continous
recevie
        MOVWF   RCSTA,A=09

Etc..

Just my 2c

/Tony

--
http://www.piclist.com hint: To leave the PICList
mailto:piclist-unsubscribe-request@mitvma.mit.edu

--
http://www.piclist.com hint: To leave the PICList
mailto:piclist-unsubscribe-request@mitvma.mit.edu