Jim Tellier wrote:

> Ok, I can't help but throw my $0.02 into this... aside from the actual code
> in question, this is more to the issue of commenting code.   (BTW, I speak
> with 32 years of SW Engr experience in myriad assembler and HLL contexts).
> The Importance of commented code *cannot* be disputed.  Period.

>HOWEVER, I
> *always* take issue with the concept of "commenting as you write it"!

I completely agree with you. It is obvious that this code

    rlf    tmp_acc,w
    rlf    acc
    clrf    tmp_acc
    movlw    1
    andwf    acc

does a 15 bit unsigned shift right of an 8 bit variable that has been
temporarily promoted to 16 bits

and it is obvious that the author of

    movf    indx,w
    addwf    base,w
    movwf    fsr
    movf    indf,w

actually ment to write

    movf    indx,w
    addlw    base
    movwf    fsr
    movf    indf,w

It is also obvious that IRP is valid and should not be touched and that adding
indx to base will never produce a carry.

> IMHO, it is an order of magnitude more useful to comment it *after* it has
> been debugged and Proven.

why bother, you know it works.

Regards
Sergio Masci

--
http://www.piclist.com hint: The list server can filter out subtopics
(like ads or off topics) for you. See http://www.piclist.com/#topics