Andrew Warren wrote:
> > >    movwf   temp
> > >    movlw   HIGH aCountsTodegC
> > >    skpnc
> > >    addlw   1
> > >    movwf   PCLATH
> > >    movf    temp,W
> > >    movwf   PCL
> >
> > You need to comment your code.  This is atrocious.
>
>     It is not.
>
>     As you know perfectly well, the code Ed shows is a very standard
>     "16-bit plus 8-bit" addition routine. Anyone capable of helping
>     Ed with his question about restoring PCLATH would also recognize
>     and understand the addition code at a glance; I don't see how
>     commenting each line of it would be either necessary or useful.


I see how commenting each line of it is necessary and useful:

Most of Piclisters don't know that "the code Ed shows is a very
standard "16-bit plus 8-bit" addition routine.
But they will know if the code would be well commented. It's a
matter of ethics to let all the members understand what's going on.

(not to say about the necessity to follow some standard rules
in coding, in engineering, in anything without permanently wasting
time on discussion are they really necessary and useful)


Regards,

Mike.

--
http://www.piclist.com hint: PICList Posts must start with ONE topic:
[PIC]:,[SX]:,[AVR]: ->uP ONLY! [EE]:,[OT]: ->Other [BUY]:,[AD]: ->Ads